Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The diagram is not loading after clicking on a tab and refreshing the page #68

Closed
oanalavinia opened this issue Sep 11, 2019 · 2 comments
Closed
Assignees
Milestone

Comments

@oanalavinia
Copy link

@oanalavinia oanalavinia commented Sep 11, 2019

Steps to reproduce

  1. Have a simple diagram
  2. Click on a tab (e.g. Attachments, History) and refresh the page

Expected result
The diagram is shown.

Actual result
The diagram remains on loading step.

Environment
XWiki 8.4.5, Chromium 71.0.3

loading

In the console I am getting Uncaught invalid block type from pako.min.js

@oanalavinia
Copy link
Author

@oanalavinia oanalavinia commented Sep 11, 2019

This issue seems to be caused by #27 since I cannot reproduce it before these changes were added.

arcilli added a commit that referenced this issue Sep 12, 2019
…reshing

the page

Added missing parameter after anchor.
@arcilli arcilli added this to the 1.8 milestone Sep 12, 2019
@arcilli
Copy link

@arcilli arcilli commented Sep 12, 2019

When a diagram is encoded (in order to be exported as URL), a parameter ('R') is added immediately after the hash symbol.

Seems like I was testing only the existence of an anchor (which is true for attachment/history sections) and not the existence of a hash with a diagram.

Thanks for reporting this.

@arcilli arcilli closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants