Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print preview feature doesn't display Diagram #72

Closed
js-ddev opened this issue Sep 24, 2019 · 1 comment

Comments

@js-ddev
Copy link

commented Sep 24, 2019

In the 1.8 release of the application, when using the Print preview in the XWiki page menu button the diagrams are not shown.
Yet they can be printed with the page, and are shown using browser's print preview feature.
Tested in Firefox and Chrome, last releases, on Ubuntu:
Diagram-XWiki-preview
Diagram-browser-preview

@mflorea

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

There are 2 sides of the problem:

  • print.vm (activated by xpage=print) doesn't include javascript.vm and so the JavaScript of the diagram viewer is not loaded in print preview, which is probably expected since PDF export can't use the JavaScript code
  • The diagram view sheet only checks for export action.
@mflorea mflorea self-assigned this Oct 1, 2019
@mflorea mflorea added this to the 1.9 milestone Oct 1, 2019
@mflorea mflorea closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.