Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save image attachments in the diagram source using their reference instead of their URL #86

Closed
mflorea opened this issue Nov 20, 2019 · 0 comments

Comments

@mflorea
Copy link
Collaborator

mflorea commented Nov 20, 2019

ATM when you insert / upload an image from your computer, the image is attached to the diagram page and when you save the diagram the diagram source contains the attachment URL. This makes it hard to refactor the diagram source when the attachment or the diagram page is renamed / moved. Moreover, when you edit the image from the diagram editor you see the attachment URL.

The goal of this issue is to:

  • the source of the diagram should contain the attachment reference when the diagram is saved, and not the attachment URL
  • when editing the attached image, the user should see the attachment reference, and they should be able to enter a different attachment reference.
@mflorea mflorea added this to the 1.11 milestone Nov 20, 2019
@mflorea mflorea self-assigned this Nov 20, 2019
mflorea added a commit that referenced this issue Nov 20, 2019
@mflorea mflorea closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant