Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Null' value displayed when no repeat frequency is selected #23

Closed
ilieandriuta opened this issue Oct 26, 2018 · 0 comments

Comments

@ilieandriuta
Copy link

commented Oct 26, 2018

STEPS TO REPRODUCE

  1. Login with Admin
  2. Go to Flash Messages App from Apps Panel
  3. Click on 'Create'
  4. Type a name for the new flash message
  5. Click 'Create'
  6. Select a Start Date (e.g. Now)
  7. Click in Groups field and type a group name (e.g. XWikiAllGroup)
  8. Select Repeat: Yes
  9. Select 'Repeat Interval': Daily, Weekly, Monthly, Yearly
  10. Observe the 'Repeat Summary' field

EXPECTED RESULTS

In the 'Repeat Interval' is displayed 'Every - days', or weeks/months/years due tot the fact that the 'Repeat frequency' is not selected (has the value '---').

ACTUAL RESULTS

Instead, when 'Repeat frequency' is not selected (has the default value) is displayed 'Every null days/weeks/months/years'.

If both 'Repeat interval' and 'Repeat frequency' have '---' (default value), in 'Repeat Summary' is displayed 'Every null flash.repeat.summary.' In this situation, it could have the value 'Please select a Repeat Interval and Frequency first.'

Environment: Windows 10 Pro 64 bit, Chrome 70, using a local instance XWiki 10.8.1 on PostgreSQL 10

flash_days

flash_months

flash_summary

flash_weeks

flash_years

@ilieandriuta ilieandriuta added this to the 1.4 milestone Oct 26, 2018

@oanalavinia oanalavinia modified the milestones: 1.4, 2.0 Feb 20, 2019

@arcilli arcilli self-assigned this Jul 22, 2019

arcilli added a commit that referenced this issue Jul 24, 2019

Applied formatting
'Null' value displayed when no repeat frequency is selected #23

acotiuga added a commit that referenced this issue Jul 24, 2019

Merge pull request #41 from xwikisas/issue#23
Issue #23: 'Null' value displayed when no repeat frequency is selected

@arcilli arcilli closed this Jul 24, 2019

@acotiuga acotiuga modified the milestones: 2.0, 1.4.5 Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.