Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when displaying the user name in the poll table #32

Closed
vmassol opened this issue Feb 22, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@vmassol
Copy link

commented Feb 22, 2019

team_activity___cooking_workshop__xpoll_team_activity____cooking_workshop_webhome__-_xwiki

@vmassol

This comment has been minimized.

Copy link
Author

commented Feb 22, 2019

The problem is that wiki=true is used in {{html clean='false' wiki='true'}} and the URL inside the HREF is parsed as wiki content... (since getUserName() returns HTML).

@vmassol

This comment has been minimized.

Copy link
Author

commented Feb 22, 2019

Idea: use a better displayer for the user. We have displayers showing both avatars and name.

@lucaa

This comment has been minimized.

Copy link

commented Feb 24, 2019

Quick solution: getUserName() takes a second parameter controlling whether html should be generated or not - so replacing all getUserName(user) with getUserName(user, false) does the job
Long solution: proper sheet that avoids using {{html wiki=true }} (which is generally a bad idea and the proof of that is this issue). This solution could, as Vincent said, also include an improvement of the user display.

@oanalavinia oanalavinia self-assigned this Mar 20, 2019

oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Mar 26, 2019

Bug when displaying the user name in the poll table xwikisas#32
* used html tables for showing the table
* used a macro for displaying the user along with the avatar
* indentation

oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Mar 27, 2019

acotiuga added a commit that referenced this issue Mar 27, 2019

Bug when displaying the user name in the poll table #32 (#38)
* Bug when displaying the user name in the poll table #32
* used html tables for showing the table
* used a macro for displaying the user along with the avatar
* indentation

@acotiuga acotiuga added this to the 11.1 milestone Mar 27, 2019

@acotiuga acotiuga closed this Mar 27, 2019

@acotiuga acotiuga modified the milestones: 11.1, 1.11, 1.10.3 Mar 27, 2019

@lucaa

This comment has been minimized.

Copy link

commented Mar 28, 2019

On a 1.10.4 version of the poll application, on a subwiki of a farm with global users , this issue is not fixed as it's replaced with a new issue: broken avatar macro and broken link to the user page:
image

I am reopening this issue also it's arguable whether the bug is a new one or the same as this one (it's obviously not the same, but the user display is still not ok).

@lucaa lucaa reopened this Mar 28, 2019

oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Mar 29, 2019

Bug when displaying the user name in the poll table xwikisas#32
* fixed for a subwiki with global users

acotiuga added a commit that referenced this issue Mar 29, 2019

Merge pull request #39 from oanalavinia/issue32
Bug when displaying the user name in the poll table #32

@oanalavinia oanalavinia modified the milestones: 1.10.3, 1.10.5 Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.