Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the current user from the others when you haven't voted yet #33

Closed
vmassol opened this issue Feb 22, 2019 · 1 comment
Closed

Separate the current user from the others when you haven't voted yet #33

vmassol opened this issue Feb 22, 2019 · 1 comment
Assignees
@oanalavinia
Labels
Priority: Major Type: Improvement
Milestone
1.10.7

Comments

@vmassol
Copy link

@vmassol vmassol commented Feb 22, 2019

Right now when you land on a poll you see a list of user votes + yourself at the bottom (without any separation).

It's hard to understand that you're listed because you haven't voted yet whereas the others are listed because they have voted.

I thought that the list was fixed... And thus I asked myself why are there some people missing in the list...
@vmassol
Copy link
Author

@vmassol vmassol commented Feb 22, 2019

team_activity___cooking_workshop__xpoll_team_activity____cooking_workshop_webhome__-_xwiki

Loading

@oanalavinia oanalavinia self-assigned this Apr 23, 2019
oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue May 22, 2019
@oanalavinia @oanalavinia
Separate the current user from the others when you haven't voted yet x…
1a29933 
…wikisas#33

* added a row that will separate the user
oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Jun 4, 2019
@oanalavinia @oanalavinia
Separate the current user from the others when you haven't voted yet x…
c0c4e52 
…wikisas#33

* users are ordered considering when they have voted
* the current user is separated using a background color and a bold font
* arrange the display of the a user
oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Jun 4, 2019
@oanalavinia @oanalavinia
Separate the current user from the others when you haven't voted yet x…
906156b 
…wikisas#33

* changed a line with more than 120 characters.
oanalavinia added a commit to oanalavinia/application-xpoll that referenced this issue Jun 20, 2019
@oanalavinia @oanalavinia
Separate the current user from the others when you haven't voted yet x…
cde2d4b 
…wikisas#33

* add as dependency the macro used in displaying the users
* fixed tests to use an existent user instead of superadmin
acotiuga added a commit that referenced this issue Jun 20, 2019
@oanalavinia @oanalavinia @acotiuga
Separate the current user from the others when you haven't voted yet #33
e5eaaa7 
 (#40)

* Separate the current user from the others when you haven't voted yet #33
* added a row that will separate the user
* users are ordered considering when they have voted
* the current user is separated using a background color and a bold font
* add as dependency the macro used in displaying the users
* fixed tests to use an existent user instead of superadmin
@acotiuga acotiuga added this to the 1.10.7 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: Improvement
Projects
None yet
Milestone
1.10.7
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@vmassol @acotiuga @oanalavinia