Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate users in the userList macro #114

Closed
slauriere opened this issue Mar 6, 2023 · 1 comment
Closed

Deduplicate users in the userList macro #114

slauriere opened this issue Mar 6, 2023 · 1 comment
Assignees
@raphj
Labels
Macro: Userlist Type: Bug
Milestone
1.11.0

Comments

@slauriere
Copy link
Contributor

slauriere commented Mar 6, 2023 •
edited by raphj

Users should be deduplicated when present both as user and member of a listed group, and in any occasion where users can be duplicated.

Steps to reproduce

Create user list with users="XWiki.Admin" and groups="XWiki.AdminGroup"

Actual result

The user list displays XWiki.Admin twice instead of once
@raphj raphj changed the title Users should be deduplicated when present both as user and member of a listed group Deduplicate users in the userList macro Oct 18, 2023
raphj added a commit that referenced this issue Oct 18, 2023
@raphj
#114 Deduplicate users in the userList macro
8a5b246
@raphj
Copy link
Contributor

raphj commented Oct 18, 2023

Fixed.

The fix is boring and unsurprising: I changed the ArrayList usage to a HashSet.

@raphj raphj closed this as completed Oct 20, 2023
@raphj raphj added this to the 1.11.0 milestone Oct 23, 2023
raphj added a commit that referenced this issue Oct 23, 2023
@raphj
#114 Deduplicate users in the userList macro
c2b82f6
raphj added a commit that referenced this issue Oct 23, 2023
@raphj
#114 Deduplicate users in the userList macro
e2f27e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphj raphj

Labels
Macro: Userlist Type: Bug
Projects
No open projects
ProAppsRoadmapOct-Dec2023
Status: Done
Milestone
1.11.0
Development

No branches or pull requests
2 participants
@slauriere @raphj