The Recently Updated macro is not filtering properly on spaces

[aubincleme]

Steps to reproduce :

• In a blank wiki, import the tree of pages that can be found in this XAR : https://up1.xwikisas.com/#hdhXEly45C0VXOEhRZP4Dw
• Head to Test Space.WebHome
• Observe that the recently updated macro shows updates from pages that are part of Test Space 2 and not part of Test Space.

This is unexpected as the recently updated macro should filter by default on the recent updates of the space it is currently defined in.

[aubincleme]

I tired adding the following code in #queryPages of Confluence.Macros.RecentlyUpdatedService, which seems to sort of resolve the issue, but needs to be integrated further into the service :

  #if ("$!options.spaces" != '')
    ## Note : this is only splitting the list of spaces based on the comma separator, however the documentation of the Recently Updated macro in Confluence DC specifies that spaces could also be separated per space. This would be causing an issue in XWiki because spaces can contain space chars in their name. See https://confluence.atlassian.com/doc/recently-updated-macro-139519.html
    #foreach($space in $options.spaces.split(','))
      #if ($foreach.count == 1)
        #set($spaceSelector = "${escapetool.q}$!{space}${escapetool.q}")
      #else
        #set($spaceSelector = "$!{spaceSelector} OR ${escapetool.q}$!{space}${escapetool.q}")
      #end
    #end
    <h1>Got spaces : $!{spaceSelector}</h1>
    #set ($discard = $fq.add("space_prefix:($!{spaceSelector})"))
  #end

[raphj]

I integrated and tested your code. it seems to work well.

I would add the space (' ') to the split regex if we knew people only used the recently updated macro from a confluence migration.

[aubincleme]

Indeed, we could add it, but it could be exposed as a parameter disabled by default : this way, if anybody inserts the recently updated macro through the WYSIWYG editor, then the parameter is not enabled, and it would allow supporting XWiki spaces (which can contain spaces in their reference). Le mer. 11 oct. 2023 à 16:28, raphj ***@***.***> a écrit :

…

I integrated and tested your code. it seems to work well. I would add the space (' ') to the split regex if we knew people only used the recently updated macro from a confluence migration. — Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNJ5734WY22EPLBHBIXHDDX62UKBANCNFSM6AAAAAA52JPLLI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- *Clément ***@***.*** ***@***.***> www.caubin.fr

[raphj]

Indeed, we could add it, but it could be exposed as a parameter disabled by
default

I'll open a new ticket for this so we can discuss it further. The issue I have with disabled by default is that it might still break confluence migrations. Unless we can add a parameter from the confluence migrator.

[raphj]

#167