Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Excerpt Include confluence bridge macro #26

Closed
ldubost opened this issue Mar 1, 2021 · 5 comments
Closed

Implement the Excerpt Include confluence bridge macro #26

ldubost opened this issue Mar 1, 2021 · 5 comments
Assignees
Milestone

Comments

@ldubost
Copy link
Contributor

ldubost commented Mar 1, 2021

Doc: https://confluence.atlassian.com/doc/excerpt-include-macro-148067.html


See #13.
Requires https://jira.xwiki.org/browse/CONFLUENCE-75

@petrenkonikita112263
Copy link

It can be closed

@raphj raphj changed the title Excerpt Include macro Implement the Excerpt Include confluence bridge macro Nov 7, 2023
@raphj
Copy link
Contributor

raphj commented Nov 7, 2023

It can be closed

Now it can, I just implemented it :-)

using https://forum.xwiki.org/t/macros-comparable-to-confluence-excerpt-and-excerpt-include/5938/3

@raphj raphj self-assigned this Nov 7, 2023
@raphj raphj closed this as completed Nov 7, 2023
@raphj raphj modified the milestones: Future, 1.12.1 Nov 7, 2023
@raphj
Copy link
Contributor

raphj commented Nov 7, 2023

This feature relies on these two fixes:

Released in confluence-xml 9.27.0 and confluence-migrator-pro 1.4.0.

@vmassol
Copy link

vmassol commented Nov 7, 2023

@raphj cool, thanks. Note that it may be missing some tests. I see it's been written as a wiki macro. I don't know if it's a best practice for the pro macros but it's a bit more complex to write tests for it than in java (which is one reason that for XWiki Standard, we usually develop our macros in java). YMMV.

@raphj
Copy link
Contributor

raphj commented Nov 13, 2023

Note that it may be missing some tests

Yeah, there's no automatic tests in pro macros.

I'm not quite knowledgeable enough to setup such tests, but would write tests if something like this existed. I would let the people leading this project setup something like this if they see fit. I think pro macros mostly rely on manual tests.

These bridge macros are quite simple and are usually thin wrappers around actual XWiki macros that are properly tested. Of course nothing is foolproof and of course, these bridge macros are occasionally somewhat more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants