Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Fix "load new articles" when the AMP plugin is disabled #77

Closed
ThierryA opened this issue Feb 7, 2018 · 3 comments
Closed

Fix "load new articles" when the AMP plugin is disabled #77

ThierryA opened this issue Feb 7, 2018 · 3 comments
Assignees
@ThierryA
Labels
Sprint 4
Projects
v0.1
Milestone
v0.1

Comments

@ThierryA
Copy link
Contributor

ThierryA commented Feb 7, 2018

The "load new articles" is displayed when the AMP plugin is disabled, see below
screen shot 2018-02-07 at 3 22 10 pm
@ThierryA ThierryA added this to the v0.1 milestone Feb 7, 2018
@delawski
Copy link
Collaborator

delawski commented Feb 7, 2018

@ThierryA @westonruter Do you think this button should be hidden with CSS or rather in PHP by testing if AMP plugin is enabled? I'm opting for the latter.

@delawski
Copy link
Collaborator

delawski commented Feb 7, 2018

Actually the button is now hidden by default with CSS and AMP is only showing it when needed with display: block. In such case when the plugin is disabled, there's nothing that would turn it on.

I just had to replace AMP-specific selector amp-live-list with a class .live-list and update the markup. This is going to be soon pushed in a PR with front-end fixes.

@delawski delawski self-assigned this Feb 7, 2018
@delawski
Copy link
Collaborator

delawski commented Feb 7, 2018

This should be fixed in the following PR: #78

@delawski delawski assigned ThierryA and unassigned delawski Feb 7, 2018
@delawski delawski mentioned this issue Feb 8, 2018
Merged
@ThierryA ThierryA added this to Ready for Merging in v0.1 Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThierryA ThierryA

Labels
Sprint 4
Projects
v0.1
Ready for Merging
Milestone
v0.1
Development

No branches or pull requests
2 participants
@delawski @ThierryA