This repository has been archived by the owner on Oct 10, 2018. It is now read-only.
Issues #75, #76, #77: fix various front-end issues. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2018
Closed
kopepasah
suggested changes
Feb 7, 2018
comments.php
Outdated
| <button on="tap:amp-live-comments-list-<?php the_ID(); ?>.update"> | ||
| <?php esc_html_e( 'New comment(s)', 'ampconf' ); ?> | ||
| </button> | ||
| <div update on="tap:amp-live-comments-list-<?php the_ID(); ?>.update" class="live-list__button"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
home.php
Outdated
| <amp-live-list id="ampconf-featured-articles-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="3"> | ||
| <button class="button" update on="tap:ampconf-articles-list.update,ampconf-featured-articles-list.update"><?php esc_html_e( 'Load Newer Articles', 'ampconf' ); ?></button> | ||
| <amp-live-list id="ampconf-featured-articles-list" class="live-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="3"> | ||
| <div class="live-list__button" update on="tap:ampconf-articles-list.update,ampconf-featured-articles-list.update"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
home.php
Outdated
| @@ -70,7 +72,9 @@ | |||
| ?> | |||
| </div> | |||
|
|
|||
| <button class="button" update on="tap:ampconf-articles-list.update<?php echo esc_attr( ( ! is_paged() ) ? ',ampconf-featured-articles-list.update' : '' ); ?>"><?php esc_html_e( 'Load Newer Articles', 'ampconf' ); ?></button> | |||
| <div class="live-list__button" update on="tap:ampconf-articles-list.update<?php echo esc_attr( ( ! is_paged() ) ? ',ampconf-featured-articles-list.update' : '' ); ?>"> | |||
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
page.php
Outdated
| <amp-live-list id="ampconf-live-page-<?php the_ID(); ?>" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="1"> | ||
| <button update on="tap:ampconf-live-page-<?php the_ID(); ?>.update" class="button"><?php esc_html_e( 'Load updates!', 'ampconf' ); ?></button> | ||
| <amp-live-list id="ampconf-live-page-<?php the_ID(); ?>" class="live-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="1"> | ||
| <div update on="tap:ampconf-live-page-<?php the_ID(); ?>.update" class="live-list__button"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
single.php
Outdated
| <amp-live-list id="ampconf-live-post-<?php the_ID(); ?>" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="1"> | ||
| <button update on="tap:ampconf-live-post-<?php the_ID(); ?>.update" class="button"><?php esc_html_e( 'Load updates!', 'ampconf' ); ?></button> | ||
| <amp-live-list id="ampconf-live-post-<?php the_ID(); ?>" class="live-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="1"> | ||
| <div update on="tap:ampconf-live-post-<?php the_ID(); ?>.update" class="live-list__button"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
templates/live-lists/posts.php
Outdated
| <amp-live-list id="ampconf-posts-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="<?php echo esc_attr( get_option( 'posts_per_page' ) ); ?>"> | ||
| <button update on="tap:ampconf-posts-list.update" class="button"><?php esc_html_e( 'Load Newer Articles', 'ampconf' ); ?></button> | ||
| <amp-live-list id="ampconf-posts-list" class="live-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="<?php echo esc_attr( get_option( 'posts_per_page' ) ); ?>"> | ||
| <div update on="tap:ampconf-posts-list.update" class="live-list__button"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
templates/more-stories.php
Outdated
| <?php esc_html_e( 'Load Newer Stories', 'ampconf' ); ?> | ||
| </button> | ||
| <amp-live-list id="more-stories" class="live-list" data-poll-interval="<?php echo esc_attr( AMPCONF_LIVE_LIST_POLL_INTERVAL ); ?>" data-max-items-per-page="<?php echo esc_attr( $max_shown ); ?>"> | ||
| <div update on="tap:more-stories.update" class="live-list__button"> |
There was a problem hiding this comment.
The on action here should be on the button element, not the parent div.
|
@westonruter |
kopepasah
approved these changes
Feb 8, 2018
|
Changes have been deployed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78.
Fixes #76.
Fixes #77.