Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Color Palette/Picker #45

Closed
ravichdev opened this issue Feb 17, 2020 · 5 comments · Fixed by #47 or #55
Closed

Component: Color Palette/Picker #45

ravichdev opened this issue Feb 17, 2020 · 5 comments · Fixed by #47 or #55
Assignees
Labels
Projects

Comments

@ravichdev
Copy link
Contributor

ravichdev commented Feb 17, 2020

Feature description

Related to #9

Extend Gutenberg color palette component to show all Material color palettes and adjust styles to show all material shades of a color in a single row.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The color picker uses the default core component as its base, and adds a few additional style changes.
  • The tooltip description will show the color name, such as Pink 400, instead of the hex.
  • This color picker will be used in Blocks (such as Button) where choosing a material color is preferred over the default settings.
  • Custom color will default to the color picker in Gutenberg.

Screen Shot 2020-02-18 at 7 48 52 AM

Implementation brief

  • Extend Gutenberg ColorPalette component with colors set as material colors
  • Update styles to show all colors in a shade in a single row

QA testing instructions

Demo

Changelog entry

@ravichdev ravichdev mentioned this issue Feb 18, 2020
3 tasks
@ravichdev ravichdev self-assigned this Feb 18, 2020
@ravichdev ravichdev added this to In Progress in Execution Feb 18, 2020
@ravichdev
Copy link
Contributor Author

@jwold Material Color Palette with scroll, if we limit the height to around 200px we see these scroll bars, but if we dont specify height the colors seem to be too long. Your thoughts ?

Screen Recording 2020-02-19 at 12 36 PM

Execution automation moved this from In Progress to Done Feb 19, 2020
@jwold
Copy link

jwold commented Feb 19, 2020

@ravichdev I agree that we should limit height. 200px feels like a good height for now.

@derekherman
Copy link
Contributor

@ravichdev and @jwold let's update the issue with all the info i.e. QA testing instructions, Demo, and Changelog entry before merging the PRs.

@jwold
Copy link

jwold commented Feb 21, 2020

I've updated the Acceptance Criteria for this subtask to be specific to the Color Picker.

@ravichdev ravichdev reopened this Feb 26, 2020
Execution automation moved this from Done to In Progress Feb 26, 2020
@ravichdev ravichdev moved this from In Progress to Code Review in Execution Feb 27, 2020
@ravichdev
Copy link
Contributor Author

@jwold Most of the color palette is re-written to look like the design shared in the main issue. Just a minor change is showing the color palette in a dropdown (similar to how the color picker) is showed so it's consistent with the color picker behavior.

Screen Recording 2020-02-27 at 07 21 PM

@jwold jwold changed the title Component: Color Palette/Picker 2️⃣Component: Color Palette/Picker Mar 5, 2020
@jwold jwold added the Sprint 2 label Mar 6, 2020
@jwold jwold changed the title 2️⃣Component: Color Palette/Picker Component: Color Palette/Picker Mar 6, 2020
Execution automation moved this from Code Review to Done Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Execution
  
Done
3 participants