Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block: Extend curated card collection to support Custom Post Types #66

Closed
jwold opened this issue Mar 3, 2020 · 7 comments
Closed

Block: Extend curated card collection to support Custom Post Types #66

jwold opened this issue Mar 3, 2020 · 7 comments
Assignees
Projects
Milestone

Comments

@jwold
Copy link

jwold commented Mar 3, 2020

Feature description

Currently the Curated Card Collection block allows for creating cards based on posts. We'd like to extend that to include cards from pages, and custom post types.

Inspiration: Hand-picked Products

Sorting: Need to think about that and the accessibility. (And filtering)


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Screen Shot 2021-01-14 at 11 44 54 AM

  1. When using Curated Card Collection, I am able to filter by:
    1. Posts and pages
    2. Custom post types
  2. As an editor, I am only able to select one content type at a time
  3. When displaying filtering options, performance should be considered (See how curated block has a search and scrolling list of posts)
  4. Only display the radio buttons for content selection if custom post types are available.
  5. By default make posts and pages selected
  6. Add ability to sort chosen cards hold for now JNW
  7. Extend recent posts block as well. Hold for now JNW

Implementation brief

QA testing instructions

Demo

Changelog entry

@jwold jwold added this to Prioritization in Definition via automation Mar 3, 2020
@jwold jwold moved this from Prioritization to Revisit Later in Definition Mar 3, 2020
@jwold
Copy link
Author

jwold commented Apr 10, 2020

  • Thinking about leveraging with something like Woo. We cover blocks for post/page.
  • If a site has a product, can I leverage other plugin data output
  • If I'm using an existing Woo block, maybe on onboarding I have a button that says put the steel hammer on overriding what that looks like.
  • Next step is to see if there's any specifics to tackle.
  • Products for Woo, Events for Events calendar.
  • People may use CPT in interesting ways. Translations and duplicate content.
  • From the engineering side if we hotwire block to support any CPT
  • New AC: supports any CPT with title, content (such as recipes)
  • Create new issue for situation where we want to explore matching other plugin functionality
  • Not phase 2, but would like to hear if this is requested

@jwold jwold added the Phase 2 label Apr 29, 2020
@jwold jwold added Phase 3 and removed Phase 2 labels Jun 10, 2020
@jwold
Copy link
Author

jwold commented Sep 25, 2020

This is useful, but I think it’s ok to wait until a need arises.

@jwold jwold closed this as completed Sep 25, 2020
@jauyong jauyong removed this from Revisit Later in Definition Dec 10, 2020
@jauyong jauyong added this to Backlog in Execution Dec 10, 2020
@jauyong jauyong self-assigned this Dec 10, 2020
@jauyong
Copy link

jauyong commented Dec 10, 2020

Reopening after discussing with Rody on 12/7

@jauyong jauyong reopened this Dec 10, 2020
@jauyong
Copy link

jauyong commented Dec 10, 2020

Next step is to get an IB written

@jauyong jauyong moved this from Backlog to To Do in Execution Dec 16, 2020
@jauyong jauyong assigned jwold and unassigned jauyong Dec 16, 2020
@jauyong
Copy link

jauyong commented Dec 18, 2020

@jwold to give input on UX and meet with an engineer to validate functionality

@jwold jwold changed the title Block: Posts extension Block: Extend recent and hand-picked posts to support CPT and filtering Jan 14, 2021
@jwold jwold changed the title Block: Extend recent and hand-picked posts to support CPT and filtering Block: Extend curated card collection to support Custom Post Types Jan 14, 2021
@jwold jwold assigned jauyong and unassigned jwold Jan 14, 2021
@jwold
Copy link
Author

jwold commented Jan 14, 2021

@jauyong this is ready for an engineer to review, or for the team to discuss in backlog grooming.

@jauyong jauyong removed their assignment Jan 15, 2021
@technosailor technosailor moved this from To Do to In Progress in Execution Jan 27, 2021
@technosailor
Copy link

Leaving this for someone to pickup as I offboard.

Most of this is done (I believe).

  • UX update to include post types. (CPTs included are all that have show_in_rest and are not post, page, attachment, or wp_block)
  • Enable "state" on the radio button
  • Create REST API endpoint for retrieving multiple post types. In practice, this is only needed for "Posts and Pages" because UX is radio button and only one can be selected. Only P&P represents multiple post types. Endpoint is /material-design/v1/post-types/get-posts
  • Component for retrieving posts with apiFetch when using the custom end point. Default usage for CPTs is to use core REST API modules that already exists.
  • Do the logic modification for which radio is is checked and alter REST API endpoint integration

@technosailor technosailor moved this from In Progress to To Do in Execution Feb 12, 2021
@jauyong jauyong removed the Phase 3 label Feb 26, 2021
@ravichdev ravichdev moved this from To Do to In Progress in Execution Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Execution
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants