Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA4 ID admin setting persist #109

Closed
mehigh opened this issue Jul 14, 2023 · 0 comments · Fixed by #111
Closed

GA4 ID admin setting persist #109

mehigh opened this issue Jul 14, 2023 · 0 comments · Fixed by #111
Assignees

Comments

@mehigh
Copy link
Member

mehigh commented Jul 14, 2023

When configuring GA4 ID, the setting does not persist in the administrative interface:

Screenshot 2023-07-14 at 11 06 46

The setting is saved in the database and used for outputting the code correctly

","ga4_id":"UA-1234588"},"chance":"1"};

Problem is reproducible with version 1.3.

Probably it's around this area of the code:
https://github.com/xwp/site-performance-tracker/blob/master/php/src/class-analyticsidfield.php#L53C9-L55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants