Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IN and NOT IN queries #1011

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix IN and NOT IN queries #1011

wants to merge 5 commits into from

Conversation

kasparsd
Copy link
Contributor

@kasparsd kasparsd commented Jun 24, 2019

Fixes #977.

  • Fix the core issue with preparing multiple values for IN and NOT IN queries.
  • Add unit tests for the new helper methods and the core DB query logic. Finished and confirmed by @kidunot89 馃憤

@lkraav
Copy link
Contributor

lkraav commented Sep 27, 2019

Sup @kasparsd anything I can do to help here? Where did it get stuck?

@kasparsd
Copy link
Contributor Author

@lkraav I started working on this before we had the dev environment bundled with the plugin which can run unit tests, so the remaining job is to add the unit tests and do some smoke testing with some actual data.

@kopepasah kopepasah added this to Reviewing in Kanban Jul 30, 2020
@kopepasah kopepasah moved this from Reviewing to Doing in Kanban Jul 30, 2020
@kidunot89 kidunot89 changed the base branch from master to develop August 25, 2020 00:04
@kidunot89 kidunot89 requested review from kidunot89 and removed request for kidunot89 August 25, 2020 00:04
@kidunot89
Copy link
Contributor

@kasparsd All ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Kanban
  
Doing
Development

Successfully merging this pull request may close these issues.

None yet

3 participants