Remove plugin uninstallation flow #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
changed the title
schlessera
changed the title
3 tasks
kasparsd
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426.
Supersedes #1431.
This PR removes the uninstallation logic for now.
During the work on PR #1431, we realized that the uninstallation logic is way more broken than only a missing nonce, and the general user interaction flow does not properly add up. Fixing this is not only very involved, but also makes way more drastic changes to the plugin than we feel comfortable doing within the scope of a security hotfix.
To fix the currently divulged security vulnerability, we now decided to remove the uninstallation for now (which makes the missing nonce a non-issue, of course) and give ourselves the time to properly rethink the uninstallation user flow in a larger update.
Checklist
contributing.md).