Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/132 amp featured image #138

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix/132 amp featured image #138

merged 2 commits into from
May 27, 2020

Conversation

ravichdev
Copy link
Contributor

@ravichdev ravichdev commented May 27, 2020 •
edited
Loading

Summary

Fixes #132

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • [] My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@spacedmonkey
Copy link
Contributor

Tested this locally and works great!

spacedmonkey
spacedmonkey approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and great fix.

@spacedmonkey spacedmonkey merged commit f48b3b7 into develop May 27, 2020
@derekherman derekherman deleted the fix/132-amp-featured-image branch July 2, 2020 03:03
@spacedmonkey spacedmonkey mentioned this pull request Aug 3, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Set Featured Image in Gutenberg when AMP plugin active
2 participants
@ravichdev @spacedmonkey