Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files in js coverage #149

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Ignore files in js coverage #149

merged 2 commits into from
Jun 3, 2020

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented Jun 2, 2020

Summary

Remove polyfill and admin bootstrap file from code coverage.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@spacedmonkey spacedmonkey changed the title [WIP] Ignore files. Ignore files in js coverage Jun 2, 2020
@@ -2,3 +2,4 @@
* Internal dependencies
*/
import './style.css';
/* istanbul ignore file */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacedmonkey could you move /* istanbul ignore file */ to the beginning of all the files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a nitpick, I just prefer to have it at the beginning of the file with a line break after it.

@derekherman derekherman merged commit f2d6d38 into develop Jun 3, 2020
@derekherman derekherman deleted the fix/codecoverage branch July 2, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants