Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VIP Go coding standards against JS as well. #183

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

spacedmonkey
Copy link
Contributor

Summary

Run VIP Go coding standards against JS as well.

After a Discussion with @ravichdev , it was decided it would be cleaner to add these a new standards file, that just implements just the VIP GO standards.

Fixes #

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, formatting and linting works well with the VIP standards.

@spacedmonkey
Copy link
Contributor Author

We can't merge this until #181 . I will rebase after this.

@spacedmonkey spacedmonkey merged commit fa1de87 into develop Jun 26, 2020
@derekherman derekherman deleted the feature/lint-js branch June 29, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants