Skip to content
This repository has been archived by the owner on Aug 24, 2018. It is now read-only.

Captioned images overflow sidebar #13

Closed
obenland opened this issue Mar 10, 2017 · 6 comments
Closed

Captioned images overflow sidebar #13

obenland opened this issue Mar 10, 2017 · 6 comments

Comments

@obenland
Copy link
Contributor

Because captions get a hardcoded pixel width, they almost always overflow the sidebar. Fixing this would require changing the core shortcode to accept inline styles

@melchoyce
Copy link
Contributor

Should we open a core ticket for this?

@obenland
Copy link
Contributor Author

Maybe. I don't know, could be part of this plugin too

@melchoyce
Copy link
Contributor

I feel like we don't have this problem in galleries, so it might be the plugin, not core.

@obenland
Copy link
Contributor Author

I don't think galleries use the shortcode though, do they? I mean the easiest way to mitigate it would be to make the short code more flexible so that we can pass our own styles and override the fixed width.

@melchoyce
Copy link
Contributor

I don't think galleries use the shortcode though, do they?

¯_(ツ)_/¯

I mean the easiest way to mitigate it would be to make the short code more flexible so that we can pass our own styles and override the fixed width.

Sounds good to me 👍

@obenland
Copy link
Contributor Author

I tested the caption shortcode with all twenty themes, the overflow issue is only present in Twenty Ten (which I had active when I noticed).
Twenty Ten sets a pixel max-wdith with an !important flag.
Twenty Sixteen doesn't clear floats in widgets, which leads to broken layouts when inserting a floated image. Images are floated left by default.

obenland added a commit that referenced this issue Mar 17, 2017
Twenty Ten doesn’t handle overflowing captions correctly.
Twenty Sixteen doesn’t clear floats inside widgets.

See
#13 (comment)
05452
Fixes #13.
obenland added a commit that referenced this issue Mar 17, 2017
Twenty Ten doesn’t handle overflowing captions correctly.
Twenty Sixteen doesn’t clear floats inside widgets.

See
#13 (comment)
05452
Fixes #13.
obenland added a commit that referenced this issue Mar 17, 2017
Twenty Ten doesn’t handle overflowing captions correctly.
Twenty Sixteen doesn’t clear floats inside widgets.

See
#13 (comment)
05452
Fixes #13.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants