Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Select2 As a Dependency for Script #199

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
2 participants
@johnregan3
Copy link
Contributor

commented Jul 22, 2016

Adds 'select2' to the dependency array for customize-posts-panel script.

On a fresh WP install, the customizer was not fully loading due to a JS error.

screen shot 2016-07-22 at 4 54 20 pm

Upon investigation, it was found that it was due to Select2 not being loaded into the page.

@westonruter westonruter added this to the 0.7 milestone Jul 22, 2016

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

@johnregan3 It's good you caught this! It probably wasn't noticed previously because we've been including the Customize Object Selector plugin which also includes a copy of Select2, and it probably enqueued it first.

@westonruter westonruter merged commit 7f11920 into develop Jul 22, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on develop at 92.256%
Details

@westonruter westonruter deleted the bugfix/select2-as-dependency branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.