Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 56 Post Date Control Reset UI #208

Conversation

Projects
None yet
3 participants
@ahmadawais
Copy link
Contributor

commented Aug 1, 2016

This PR refines the date reset UI. Lesser UI is better UI :)

@@ -1 +1 @@
Subproject commit ce4fce1c1489b1d61844af8ef1dffea897462b29
Subproject commit 449182d5615568beb5a406dbc5358004c29896ed

This comment has been minimized.

Copy link
@westonruter

westonruter Aug 1, 2016

Contributor

Why the submodule change?

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Aug 2, 2016

Author Contributor

Didn't do anything to it, just fetched & pulled it after there was another fix from your end.

This comment has been minimized.

Copy link
@westonruter

westonruter via email Aug 2, 2016

Contributor

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Aug 7, 2016

Author Contributor

Yes, I did miss the submodule update. Will add that to my pull and fetch bash function. Thanks!

border: none;
background: none;
color: #008ec2;
cursor: pointer;

This comment has been minimized.

Copy link
@westonruter

westonruter Aug 1, 2016

Contributor

Looks like tabs/spaces indentation inconsistencies.

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Aug 2, 2016

Author Contributor

Oh, my bad! I completely forgot my editor was set for JS-based spaces (client's requirement).

@westonruter westonruter merged commit ad6751d into xwp:feature/issue-56-post-date-control Aug 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@westonruter

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

I'll fix up these issues in the other PR. Thanks!

@ahmadawais ahmadawais deleted the ahmadawais:feature/issue-56-post-date-control branch Aug 2, 2016

@westonruter westonruter modified the milestone: 0.7 Aug 6, 2016

@@ -119,9 +120,11 @@
}
} );
control.resetTimeButton.hide();
control.resetTimeWrap.hide();

This comment has been minimized.

Copy link
@sayedtaqui

sayedtaqui Aug 7, 2016

Collaborator

Shouldn't we use addClass/removeClass with .hidden class may be, instead of show()/hide()

This comment has been minimized.

Copy link
@ahmadawais

ahmadawais Aug 7, 2016

Author Contributor

What would be the benefit of doing that?

This comment has been minimized.

Copy link
@sayedtaqui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.