This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Feature/issue 56 Post Date Control Reset UI #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1 @@ | |||
| Subproject commit ce4fce1c1489b1d61844af8ef1dffea897462b29 | |||
| Subproject commit 449182d5615568beb5a406dbc5358004c29896ed | |||
There was a problem hiding this comment.
Why the submodule change?
There was a problem hiding this comment.
Didn't do anything to it, just fetched & pulled it after there was another fix from your end.
There was a problem hiding this comment.
If you don't also do `git submodule update` when you pull, then if you do
`git commit -a` it will basically revert the upstream submodule change.
There was a problem hiding this comment.
Yes, I did miss the submodule update. Will add that to my pull and fetch bash function. Thanks!
|
I'll fix up these issues in the other PR. Thanks! |
| @@ -119,9 +120,11 @@ | |||
| } | |||
| } ); | |||
| control.resetTimeButton.hide(); | |||
| control.resetTimeWrap.hide(); | |||
There was a problem hiding this comment.
Shouldn't we use addClass/removeClass with .hidden class may be, instead of show()/hide()
There was a problem hiding this comment.
What would be the benefit of doing that?
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the date reset UI. Lesser UI is better UI :)