Abstract Editor Control #216

mohdsayed · 2016-08-09T11:14:27Z

No description provided.

…Label methods

…nto feature/editor-control

mohdsayed · 2016-08-12T17:53:41Z

@westonruter The PR is ready for review. I have tested it with multiple editor controls combinations and did not find any issue. I tried to configure pre-commit hook but could not do it correctly, so sorry for the failed checks.

westonruter · 2016-08-16T23:48:28Z

js/customize-post-section.js

 					label: postTypeObj.labels.content_field ? postTypeObj.labels.content_field : api.Posts.data.l10n.fieldContentLabel,
-					active: true,
+					setting_property: 'post_content',
 					settings: {
 						'default': setting.id


I want to see what possibilities there are for eliminating setting_property in favor of:

settings: { 'default': setting.id + '[post_content]' }

That would seem more elegant, but I think it will require a core change to support.

… expanded at once

…nto feature/editor-control

* Implement longstanding todo to improve how editor control extends the dynamic control. * Move api.EditorControl to api.Posts.PostEditorControl * Remove need to inject button since now part of template * Eliminate use of propertyElements in favor of directly mutating the setting value. * Eliminate isMeta in favor of being agnostic about what kind of setting is being modified. * Store a reference to the main textarea and re-use.

westonruter · 2016-08-18T00:18:15Z

@sayedwp this is ready for re-review. Could you give it a try with your integration?

westonruter · 2016-08-18T02:27:31Z

I'll also note that by implementing the expanded interface, expanding an editor will now work seamlessly with Customizer Browser History, automatically including the control autofocus param when the control is expanded.

mohdsayed · 2016-08-18T04:31:14Z

@westonruter Tested with my integration , works beautifully. 👍

westonruter · 2016-08-18T04:32:40Z

@sayedwp I have a proposal for something which could help disambiguate when there are multiple fields that could have an editor open:

This fixes something I noticed where I would forget what the open editor was for. If you like it, would you apply some style improvements?

mohdsayed · 2016-08-18T04:38:48Z

@westonruter I was just going to say that, and I saw your commit 😄
I had given it a thought even before, when I was going to toggle the editor animation class. I was thinking to give it tabs ( only if there are more than one editor controls) just like browser tabs. But then it will take some 50-60px of space above the editor.

westonruter · 2016-08-18T04:42:08Z

Probably shouldn't increase the overall height any. If the title is within the bar, could maybe some gray borders on either side make it feel more natural? Maybe tabs in the future of we allow more than one editor to be expanded at once.

mohdsayed · 2016-08-18T04:44:56Z

Agree on not increasing the overall height. Will add some css to make it look natural.

mohdsayed · 2016-08-18T06:03:10Z

@westonruter Is this looking good?

The icons shows that its a standard post, as shown in post editor page

westonruter · 2016-08-18T06:08:32Z

I think the icon should be omitted because the editor can be for any post type and for any meta now, so it may not make any sense as a thumbtack. Looks good otherwise!

mohdsayed · 2016-08-18T06:12:42Z

Yes, didn't think of that. And that also makes me think that why you have renamed it to "Post Editor Control" from "Editor Control"? I know it would primarily be used for post content however it would also be used for meta

westonruter · 2016-08-18T06:21:49Z

@sayedwp good point. I guess the main reason why I went with “Post” editor is that “postmeta” is still specific to posts. Also, there is a specific integration with posts in the control (the control is presumed to be added to a Post section):

wp-customize-posts/js/customize-post-editor-control.js

Lines 224 to 234 in 4dde895

    
           			/** 
        
           			 * Unlink the editor from this post and collapse the editor when the section is collapsed. 
        
           			 */ 
        
           			section.expanded.bind( function( expanded ) { 
        
           				if ( expanded ) { 
        
           					api.Posts.postIdInput.val( section.params.post_id || false ); 
        
           				} else { 
        
           					api.Posts.postIdInput.val( '' ); 
        
           					control.expanded.set( false ); 
        
           				} 
        
           			} );

westonruter · 2016-08-18T06:32:30Z

Also, I think there should be a more generic EditorControl as well, eventually. Perhaps we can eventually make PostEditorControl extend this base EditorControl.

mohdsayed · 2016-08-18T06:34:38Z

That would make more sense.

westonruter · 2016-08-18T06:51:42Z

@sayedwp cool, once you've pushed up the style changes to the editor title, I think this is good to merge.

mohdsayed · 2016-08-18T07:16:38Z

@westonruter Great, lets merge it.

…us functions

…the section

westonruter · 2016-08-18T18:55:47Z

@sayedwp I did some more cleanup of the JS and added a feature where the new editor heading will only show up if there is more than one editor control in a section. If there is only the content editor control, then there would be no need to disambiguate with other controls in the section.

valendesigns · 2016-09-11T02:18:11Z

The weird tab you guys added, which I think looks really strange sitting in the middle there, doesn't include mobile styles. So when you scale the browser down you get this.

westonruter · 2016-09-11T05:17:46Z

@valendesigns the tab is there to give the user context as to what they are editing. It appears when there are multiple editor controls in a given section.

@sayedwp would you update the styling to factor in mobile?

mohdsayed · 2016-09-12T06:15:38Z

Sure I will update that soon.

valendesigns · 2016-09-12T19:35:23Z

@westonruter I understand why it was added but from a UX perspective it's misleading. It's not a tab at all. It doesn't bind events or navigate to anything. So to clear up context we've introduced confusion elsewhere. I think it would be better if we removed the tab style and just centered the text IMO. Thoughts?

westonruter · 2016-09-12T19:54:48Z

I guess the idea is that the entire editor could be considered a tab and that's why that style was chosen. @sayedwp can you work out some non-tab styling for the heading?

mohdsayed added 9 commits August 9, 2016 14:50

Register a new control type editor

cf4a6c3

Remove post content editor code from addContentControl method

d99f6d9

Create Editor control, and register script

4986e34

Refactor injectButton resizeEditor and updateEditorToggleExpandButton…

63de4bb

…Label methods

Add names on anonymous functions

a9b0bcc

Merge branch 'develop' of https://github.com/xwp/wp-customize-posts i…

0ad0d5a

…nto feature/editor-control

Add support for postmeta in editor control

d6e40a3

Add support for multiple controls for editor

bf516e8

Add docs to the methods

c07f02b

mohdsayed changed the title ~~[WIP] Abstract Editor Control~~ Abstract Editor Control Aug 12, 2016

mohdsayed assigned westonruter Aug 12, 2016

Fix eslint and jscs issues

05bce9a

westonruter reviewed Aug 16, 2016
View reviewed changes

westonruter added 4 commits August 17, 2016 00:05

Add todo to implement control.expanded

08ac7cc

Implement expanded interface on EditorControl; ensure only one editor…

c4dc6c5

… expanded at once

Merge branch 'develop' of https://github.com/xwp/wp-customize-posts i…

948f6fc

…nto feature/editor-control

Add todos

98b7243

Add heading for editor to help indicate what the open editor is for

4dde895

westonruter mentioned this pull request Aug 18, 2016

Enhance the post editor control #221

Open

Update post editor title ui

25f266d

westonruter added 2 commits August 18, 2016 11:19

Remove bound events when editor control is removed; eliminate anonymo…

e4b2c44

…us functions

Only show editor heading if there is more than one editor control in …

ce61ab4

…the section

westonruter merged commit e647acf into develop Aug 18, 2016

westonruter added this to the 0.8 milestone Aug 18, 2016

westonruter deleted the feature/editor-control branch August 18, 2016 21:52

This was referenced Sep 16, 2016

Remove unused WP_Customize_Editor_Control class #269

Merged

ESC key causes the editor to collapse unexpectedly #281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Abstract Editor Control #216

Abstract Editor Control #216

mohdsayed commented Aug 9, 2016

mohdsayed commented Aug 12, 2016

westonruter Aug 16, 2016

westonruter commented Aug 18, 2016

westonruter commented Aug 18, 2016 via email

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016 via email

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

westonruter commented Aug 18, 2016 •

edited

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

valendesigns commented Sep 11, 2016

westonruter commented Sep 11, 2016

mohdsayed commented Sep 12, 2016

valendesigns commented Sep 12, 2016

westonruter commented Sep 12, 2016

Abstract Editor Control #216

Abstract Editor Control #216

Conversation

mohdsayed commented Aug 9, 2016

mohdsayed commented Aug 12, 2016

westonruter Aug 16, 2016

Choose a reason for hiding this comment

westonruter commented Aug 18, 2016

westonruter commented Aug 18, 2016 via email

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016 via email

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

westonruter commented Aug 18, 2016 • edited

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

mohdsayed commented Aug 18, 2016

westonruter commented Aug 18, 2016

valendesigns commented Sep 11, 2016

westonruter commented Sep 11, 2016

mohdsayed commented Sep 12, 2016

valendesigns commented Sep 12, 2016

westonruter commented Sep 12, 2016

westonruter commented Aug 18, 2016 •

edited