New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editor from inadvertently closing with ESC; ensure TinyMCE toolbars hide when collapsed #282

Merged
merged 3 commits into from Sep 19, 2016

Conversation

Projects
None yet
1 participant
@westonruter
Contributor

westonruter commented Sep 19, 2016

Fixes #281
Fixes #231

westonruter added some commits Sep 19, 2016

Prevent ESC from closing editor by stopping keydown event propagation
Also stop immediate propagation at body for any events on targets outside of customize-controls. This is a temporary measure until https://core.trac.wordpress.org/ticket/38091 lands

Fixes #281

@westonruter westonruter added this to the 0.8.0 milestone Sep 19, 2016

@westonruter westonruter merged commit 8c08d66 into develop Sep 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the bugfix/editor-fixes branch Sep 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment