This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Prevent sending back DB-persisted setting values in customize_save_response unless changeset is being published #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
reviewed
Nov 17, 2016
| ); | ||
| $changeset_status_not_publish = ( | ||
| ! empty( $response['changeset_status'] ) | ||
| && |
There was a problem hiding this comment.
For back-compat, I think this conditional needs to be:
$changeset_status_publish = (
empty( $response['changeset_status'] ) // Prior to 4.7, this filter only would run on actual saves.
||
'publish' === $response['changeset_status']
);
// Short circuit if there there were invalidities or the changeset status was not publish.
if ( $has_invalidities || ! $changeset_status_publish ) {
westonruter
changed the title
customize_save_response unless changeset is being published
westonruter
changed the title
customize_save_response unless changeset is being published
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.