This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Use auto-draft with late future date instead of customize-draft and clean auto-draft on changeset delete. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
suggested changes
Feb 28, 2017
php/class-customize-posts-plugin.php
Outdated
| continue; | ||
| } | ||
|
|
||
| // Confirm this is the only post setting. |
There was a problem hiding this comment.
Maybe, “Confirm that this changeset is the only one which references this post so it is cleared for garbage collection.”
php/class-customize-posts-plugin.php
Outdated
| foreach ( $settings_data as $setting_key => $val ) { | ||
| if ( preg_match( WP_Customize_Post_Setting::SETTING_ID_PATTERN, $setting_key, $matches ) ) { | ||
| $setting_post = get_post( $matches['post_id'] ); | ||
| if ( ! in_array( $setting_post->post_status, $status_to_delete, true ) ) { |
There was a problem hiding this comment.
This should check if $setting_post is not empty, as it could have already been deleted somehow.
php/class-customize-posts-plugin.php
Outdated
| public function cleanup_autodraft_on_changeset_delete( $post_id ) { | ||
| global $wpdb; | ||
| $post = get_post( $post_id ); | ||
| $allowed_snapshot_status = array( 'customize_changeset', 'customize_snapshot' ); |
…angeset auto-draft post_time not saving in setting post
PatelUtkarsh
changed the title
westonruter
approved these changes
Mar 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329