Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving of postmeta in scheduled changesets #375

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
1 participant
@westonruter
Copy link
Contributor

commented Nov 14, 2017

When a scheduled changeset publishes via WP Cron, the Customizer will bootstrap after the init action. In the course of normal Customizer bootstrapping, it happens at the plugins_loaded action. Because postmeta currently is registered at the init action, this means that the postmeta will not get registered during WP Cron because the Customizer will bootstrap after init.

This is also a problem for changesets that get published via WP-CLI, since init also is done before wp post update $changeset_post_id --post_status=publish.

In the Customizer the way to reproduce the problem is:

  1. Open Customizer
  2. Open a post to edit.
  3. Change the post title
  4. Change the featured image
  5. Schedule the changes to go live.
  6. At the scheduled time, the post title change is published whereas the featured image change is not.

@westonruter westonruter added the bug label Nov 14, 2017

@westonruter westonruter changed the base branch from develop to master Nov 14, 2017

@westonruter westonruter merged commit be5f816 into master Nov 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/scheduled-postmeta branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.