Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Add required PHP version go readme #160

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conversation

westonruter
Copy link
Contributor

@westonruter westonruter added this to the 0.6.3 milestone Aug 29, 2017
@valendesigns
Copy link
Contributor

@westonruter Shouldn't this be updated in the readme generator in dev-lib?

@westonruter
Copy link
Contributor Author

@valendesigns updated in what way?

@westonruter
Copy link
Contributor Author

The readme generator is copying “Requires PHP” into the markdown version.

@valendesigns
Copy link
Contributor

Add Requires PHP to this array https://github.com/xwp/wp-dev-lib/blob/master/class-wordpress-readme-parser.php#L41 and inject it into the generated readme.md

@westonruter
Copy link
Contributor Author

It doesn't seem to be required because it works without it.

@valendesigns
Copy link
Contributor

I see, so the readme generator is automatically adding Requires PHP even though it's not mentioned in the file anywhere. Awesome!

@westonruter
Copy link
Contributor Author

I think the predefined list in the script just ensures that the same order is used when generated.

@westonruter westonruter merged commit 3076044 into develop Aug 29, 2017
@westonruter westonruter deleted the add/required-php-version branch August 29, 2017 02:40
@westonruter westonruter modified the milestones: 0.6.3, 0.7.0 Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants