Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required PHP version go readme #160

Merged
merged 1 commit into from Aug 29, 2017

Conversation

Projects
None yet
2 participants

@westonruter westonruter added this to the 0.6.3 milestone Aug 29, 2017

@valendesigns

This comment has been minimized.

Copy link
Member

commented Aug 29, 2017

@westonruter Shouldn't this be updated in the readme generator in dev-lib?

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2017

@valendesigns updated in what way?

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2017

The readme generator is copying “Requires PHP” into the markdown version.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Aug 29, 2017

Add Requires PHP to this array https://github.com/xwp/wp-dev-lib/blob/master/class-wordpress-readme-parser.php#L41 and inject it into the generated readme.md

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2017

It doesn't seem to be required because it works without it.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Aug 29, 2017

I see, so the readme generator is automatically adding Requires PHP even though it's not mentioned in the file anywhere. Awesome!

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2017

I think the predefined list in the script just ensures that the same order is used when generated.

@westonruter westonruter merged commit 3076044 into develop Aug 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/required-php-version branch Aug 29, 2017

@westonruter westonruter modified the milestones: 0.6.3, 0.7.0 Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.