Implement: Show widget form controls initially in collapsed state #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </h4> | ||
| </div> | ||
| </div> | ||
| <!-- need to remove display:block --> |
There was a problem hiding this comment.
@johnregan3 is it removed?
There was a problem hiding this comment.
@westonruter Geez, yeah. I just forgot to remove my note to remove that. Ironic, huh?
Click event handlers from other controls were effecting each other. Result was the widget could not expand if there was an even number of widgets in the sidebar, since they would all cancel each other out. Use toggle code as found in WordPress core's widgets.js
Normalize JS methods to be camelCase
|
Since the widgets are collapsed by default, and since there could be any number of Text widgets (for example), it's important that the |
westonruter
added a commit
that referenced
this pull request
Sep 17, 2013
Implement: Show widget form controls initially in collapsed state Props @johnregan3 @westonruter
fnakstad
added a commit
to knishiura-lab/wp-widget-customizer
that referenced
this pull request
Feb 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds accordion-style tabs to hide/show widget interface. Causes jumpiness when widget tab expands down the page causing the scrollbar to appear. Not sure what we can do about this without forcing the scrollbar at all times.
Fixes #7