Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CPU: Lists 7 of 8 expected #19

Closed
xxxserxxx opened this issue Feb 15, 2020 · 7 comments
Closed

Missing CPU: Lists 7 of 8 expected #19

xxxserxxx opened this issue Feb 15, 2020 · 7 comments
Labels
bug Something isn't working needs:confirmation Waiting for a user to confirm an issue is resolved
Milestone

Comments

@xxxserxxx
Copy link
Owner

xxxserxxx commented Feb 15, 2020

htop shows activity on all 8 CPUs (i7 8550u)

Original cjbassi#108
Submitter @dkrieger, @syslino

@xxxserxxx
Copy link
Owner Author

Is the label not showing for the 8th CPU? If so, can you check that it's not being cropped due to the window size? Can you post a screenshot? Thanks!

@xxxserxxx
Copy link
Owner Author

gotop

using gnome-terminal on gnome 3.30.2 (wayland) @ 1440p w/ 1.2 font scaling (tested after screenshot w/ no font scaling, same result). Worth noting that running gotop in a VM running sway on arch (using termite) on this machine shows 8 cpus, and that was with the display set to 1080p.

@xxxserxxx
Copy link
Owner Author

... after trying it in a different terminal and yanking that region when running within vim, I've confirmed the 8th CPU is displayed w/ the background color, making it invisible. I'm using the bog-standard gnome-terminal solarized colorscheme. Perhaps a more conservative foreground colorscheme option would help? I noticed (less extreme) readability issues in the VM as well.

Edit: On a related note, it looks great when specifying the solarized colorscheme! From a usability perspective, I guess I'd recommend limiting the default color palette, leaving it to ricers to create an alias w/ their preferred "rich" colorscheme.

@xxxserxxx
Copy link
Owner Author

That's interesting. So the default gotop colorscheme only uses like the first 8 basic xterm colors, but it looks like your terminal solarized colorscheme is modifying those to look different. The 8th cpu line is xterm color 8 which is grey but it looks like its being changed into the solarized background color. Also, the swap line is supposed to be yellow but it looks grey in the screenshot, stuff like that.

So should we change anything in gotop? If gotop's solarized colorscheme is working for you then I would say just use that :D

@xxxserxxx
Copy link
Owner Author

Hi, I've got a very similar issue. I've got an Intel i5-5200U which should report 4 CPU's – and does so in any other monitor application. With gotop Im getting only three CPU's shown.
I'm on Arch Linux, using termite. I tried to yank the output in a nvim terminal-buffer but still – three CPU's shown (index starting at 0).

Edit: No colorscheme does work for me..

@xxxserxxx xxxserxxx added the bug Something isn't working label Feb 19, 2020
@xxxserxxx
Copy link
Owner Author

@dkrieger, @syslino, at some point in my journeys through Caleb's code I noticed in issue with color assignment where if the algorithm ran out of colors it used the background color. This was fixed in the past week or so and is available on the master branch, and in v4.0.

If either of you are still using gotop and have the ability to pull, build, and check this, I'd appreciate the confirmation that it's addressed.

Thank you

@xxxserxxx xxxserxxx added the needs:confirmation Waiting for a user to confirm an issue is resolved label May 1, 2020
@xxxserxxx xxxserxxx added this to the v4.1.0 milestone Jun 2, 2020
@xxxserxxx
Copy link
Owner Author

No response after more than a month; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:confirmation Waiting for a user to confirm an issue is resolved
Projects
None yet
Development

No branches or pull requests

1 participant