Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Temperatures shown with Raspberry Pi #6

Closed
xxxserxxx opened this issue Feb 15, 2020 · 21 comments
Closed

No Temperatures shown with Raspberry Pi #6

xxxserxxx opened this issue Feb 15, 2020 · 21 comments
Labels
bug Something isn't working dep:gopsutil
Milestone

Comments

@xxxserxxx
Copy link
Owner

xxxserxxx commented Feb 15, 2020

Hi,
I'm testing gotop Version 1.4.0 on a pi zero w with the latest image of Raspian Strech Lite.
The only problem I have is that no Temperatures are shown.

  • The output of uname -a
    Linux adc 4.14.34+ #1110 Mon Apr 16 14:51:42 BST 2018 armv6l GNU/Linux

  • Terminal shell (like zsh or bash)
    bash

  • Terminal emulator (like iTerm or gnome terminal)
    mac terminal -> ssh > server

  • Using tmux?
    no

Regards

Original ticket: cjbassi#37
Original poster: @NuggTV
Additional input: @PrivateGER, @staranto, @pgaskin, @santosh, @TheWorms, @siduxdevil, @Jpund

@xxxserxxx xxxserxxx added bug Something isn't working dep:gopsutil labels Feb 15, 2020
@xxxserxxx
Copy link
Owner Author

Hi, can you test this binary and tell me if any temperatures are shown now? I compiled that from the issue-37 branch so feel free to run that branch with the go tools instead if you want.

@xxxserxxx
Copy link
Owner Author

Hi, just testet the new binary. Still no Temperatures shown

@xxxserxxx
Copy link
Owner Author

Thanks for testing that. Since that didn't work, that means the issue is coming from one of gotop's dependencies called gopsutil. Gonna have to create an issue over there and get back to you.

@xxxserxxx
Copy link
Owner Author

Hey, are there any updates on this? I have the same problem with my Raspberry Pi with a fresh image.

@xxxserxxx
Copy link
Owner Author

Sorry, not updates yet. If you could give me the output of uname -a that would help tho.

@xxxserxxx
Copy link
Owner Author

Output is:
Linux Server-Raspberry-Pi 4.14.61-v7+ #1133 SMP Fri Aug 10 11:04:43 BST 2018 armv7l GNU/Linux

@xxxserxxx
Copy link
Owner Author

Thanks, and actually if you could give me the Raspberry Pi model # too that would be awesome.

@xxxserxxx
Copy link
Owner Author

It's a Raspberry Pi Model 3 B+.

@xxxserxxx
Copy link
Owner Author

Same issue here with...

3B+ (Linux pi99 4.14.50-v7+ #1122 SMP Tue Jun 19 12:26:26 BST 2018 armv7l GNU/Linux)
3B (Linux pi3 4.9.59-v7+ #1047 SMP Sun Oct 29 12:19:23 GMT 2017 armv7l GNU/Linux).

The gotop binary is from download.sh in commit 5b5ccfc.

@xxxserxxx
Copy link
Owner Author

This is because the temperatures for the RPi need to be retrieved using vcgencmd measure_temp or /sys/class/thermal/thermal_zone0/temp, and gopsutil gets the temperature using /sys/class/hwmon. The RPi does not support hwmon.

@xxxserxxx
Copy link
Owner Author

I'm also facing this issue of temperature not being shown.
I'm on Fedora 29 with zsh on Konsole (default settings).

@xxxserxxx
Copy link
Owner Author

@santosh Are you on a raspberry pi? If so, could you give its model and the output of uname -a? And if not, then feel free to create a new issue for your given hardware/software configuration.

@xxxserxxx
Copy link
Owner Author

same error, no temperatures shown

Linux raspberrypi 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux
Raspbian

@xxxserxxx
Copy link
Owner Author

Is there any perspective of this being fixed any time soon? I run into it with Raspbian Buster on a Pi4. Planning on writing an article for Gotop for a Linux magazine. But no temps specially on RasPi seems like a showstopper for now.

Linux raspberrypi 4.19.57-v7l+ #1244 SMP Thu Jul 4 18:48:07 BST 2019 armv7l GNU/Linux

@xxxserxxx xxxserxxx added this to the v4.0.2 milestone Jun 12, 2020
@xxxserxxx xxxserxxx modified the milestones: v4.0.2, v4.1.1 Aug 25, 2020
@xxxserxxx
Copy link
Owner Author

@NuggTV, @PrivateGER, @staranto, @pgaskin, @santosh, @TheWorms, @siduxdevil, @Jpund:

If any of you are still using gotop and Raspberry(s), can you confirm that this issue still exists? gopsutils has had numerous version bumps since the last comment by @siduxdevil

@xxxserxxx xxxserxxx added the needs:question Further information is requested label Jan 26, 2021
@Lomanic
Copy link

Lomanic commented Jan 26, 2021

@xxxserxxx Please check this comment shirou/gopsutil#391 (comment) you may have to adjust gotop as it seems to still only discriminate against _input values, excluding _thermal ones on Raspberry Pi/hosts without hwmon.

@xxxserxxx
Copy link
Owner Author

xxxserxxx commented Jan 26, 2021

@Lomanic -- how arbitrary are the strings produced by gopsutil? Checking for one magic string is suspicious; adding a variety of suffixes that could indicate temperature sensors seems suboptimal. Do you know if gopsutils is going to continue adding different suffixes for things-that-are-thermal-sensors?

Follow-up: In this comment you mention that the change wasn't made; does this mean that _thermal keys were not added? I don't have access to a Pi -- what keys are gopsutil returning now? It looks like psutil is still using _input. Are you able to confirm?

@Lomanic
Copy link

Lomanic commented Jan 27, 2021

gopsutil returns the same strings as psutil shirou/gopsutil#391 (comment) (I cannot verify this again for the moment), we aligned with psutil in shirou/gopsutil#861

@xxxserxxx
Copy link
Owner Author

Ok. There are no _thermal values returned for AMD64+Linux, only _input. If I'm understanding the (go)psutil threads, on Raspberry Pi (ARM+Linux?) the suffixes are instead _thermal. Do you know if there are other variations for other platforms?

@xxxserxxx xxxserxxx removed the needs:question Further information is requested label Jan 27, 2021
@Lomanic
Copy link

Lomanic commented Jan 27, 2021

Thermal zones are only used as a fallback on hosts lacking hwmon, the labels in /sys/class/thermal/thermal_zone*/type are quite random, for example on my amd64 laptop, cat /sys/class/thermal/thermal_zone*/type returns

acpitz
INT3400 Thermal
TSKN
NGFF
pch_skylake
B0D4
iwlwifi_1
x86_pkg_temp

@xxxserxxx
Copy link
Owner Author

Isn't the issue that -- for hwmon -- each device returns multiple sensor values; us downstream projects have to choose one of these to represent the "current temp." For hwmon, that's *_input. For thermal zones, there's a more simple .../temp value, e.g. /sys/class/thermal/thermal_zone0/temp.

In other words, on your amd64 laptop, you have 8 zones, which would explode into, I don't know, something like 48 different hwmon K/V pairs, one of which is *_input and represents the current temperature. For thermal zone systems, psutil ... what ... adds _thermal to the key that holds the value of .../temp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dep:gopsutil
Projects
None yet
Development

No branches or pull requests

2 participants