Skip to content

Commit

Permalink
Don't install dependencies for thinc-apple-ops
Browse files Browse the repository at this point in the history
thinc-apple-ops would install the pre-release version of thinc
package, which would cause error when import from thinc. All
dependencies already installed so use `--no-deps` at here is fine.
  • Loading branch information
xxyzz committed Dec 30, 2022
1 parent 6f8bc90 commit 5efeeea
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ def install_deps(pkg: str, notif: Any) -> None:
)

if ismacos and platform.machine() == "arm64":
pip_install("thinc-apple-ops", dep_versions["thinc-apple-ops"], notif=notif)
pip_install(
"thinc-apple-ops",
dep_versions["thinc-apple-ops"],
no_deps=True,
notif=notif,
)
if USE_SYSTEM_PYTHON:
pip_install("lxml", dep_versions["lxml"], notif=notif)

Expand Down Expand Up @@ -121,6 +126,7 @@ def pip_install(
pkg_version: str,
url: str | None = None,
extra_index: str | None = None,
no_deps: bool = False,
notif: Any = None,
) -> None:
pattern = f"{pkg.replace('-', '_')}-{pkg_version}*"
Expand All @@ -145,6 +151,9 @@ def pip_install(
]
)

if no_deps:
args.append("--no-deps")

if url:
args.append(url)
elif pkg_version:
Expand Down

0 comments on commit 5efeeea

Please sign in to comment.