Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Commit

Permalink
Regard gif disposal method; fix bug #18
Browse files Browse the repository at this point in the history
  • Loading branch information
Bert Münnich committed Oct 11, 2011
1 parent 71e61b1 commit 4864f04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION = git-20110929
VERSION = git-20111011

CC = gcc
CFLAGS = -Wall -pedantic -O2
Expand Down
12 changes: 7 additions & 5 deletions image.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ bool img_load_gif(img_t *img, const fileinfo_t *file) {
int intoffset[] = { 0, 4, 2, 1 };
int intjump[] = { 8, 8, 4, 2 };
int transp = -1;
unsigned int disposal = 0, prev_disposal = 0;
unsigned int delay = 0;
bool err = false;

Expand Down Expand Up @@ -178,8 +179,7 @@ bool img_load_gif(img_t *img, const fileinfo_t *file) {
if (delay)
delay = MAX(delay, MIN_GIF_DELAY);

/* TODO: handle disposal method, section 23.c.iv of
http://www.w3.org/Graphics/GIF/spec-gif89a.txt */
disposal = (unsigned int) ext[1] >> 2 & 0x7;
}
ext = NULL;
DGifGetExtensionNext(gif, &ext);
Expand Down Expand Up @@ -219,7 +219,7 @@ bool img_load_gif(img_t *img, const fileinfo_t *file) {
if (i < y || i >= y + h || j < x || j >= x + w ||
rows[i-y][j-x] == transp)
{
if (prev_frame != NULL)
if (prev_disposal != 2 && prev_frame != NULL)
*ptr = prev_frame[i * sw + j];
else
*ptr = bgpixel;
Expand All @@ -246,12 +246,14 @@ bool img_load_gif(img_t *img, const fileinfo_t *file) {
}

imlib_context_set_image(im);
prev_frame = imlib_image_get_data_for_reading_only();

imlib_image_set_format("gif");
if (transp >= 0)
imlib_image_set_has_alpha(1);

if (disposal != 3)
prev_frame = imlib_image_get_data_for_reading_only();
prev_disposal = disposal;

if (img->multi.cnt == img->multi.cap) {
img->multi.cap *= 2;
img->multi.frames = (img_frame_t*)
Expand Down

0 comments on commit 4864f04

Please sign in to comment.