Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Keys / Shortcuts #1463

Closed
dominikspiertz opened this issue Aug 23, 2021 · 2 comments
Closed

Disable Keys / Shortcuts #1463

dominikspiertz opened this issue Aug 23, 2021 · 2 comments
Assignees

Comments

@dominikspiertz
Copy link

Hello dear react-flow team,
as recently discovered, react flow now also supports specific key shortcuts for various functions. We developed with react-flow for a longer time and build a custom interface and shortcut behaviour for our react-flow visualization. Therefor we want to disable the shipped behaviour of react flow and the shortcut keys. By now we would have to provide unreachable keys like null to props like deleteKeyCode or similar. When from time to time we update react-flow and there will be more shortcuts added we will most likely miss updates and possibly break our experience on not disabled shortcuts. For us it would be the best to set a prop keys to false so we can opt-out of the provided shortcuts however they are going to improve or change. Would it be possible to have a prop like that in the near future?

@moklick
Copy link
Member

moklick commented Aug 26, 2021

Good idea. We might add it. #1370

@moklick moklick self-assigned this Aug 26, 2021
@moklick moklick added the v10 label Feb 22, 2022
@moklick
Copy link
Member

moklick commented Feb 22, 2022

We will not add a general keys option to opt-out all shortcuts but added null as a valid type to remove the handler. We only have three short cuts and we don't plan to add more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants