Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem serving files with % in filename #73

Closed
Dialga opened this issue Jun 9, 2021 · 5 comments
Closed

Problem serving files with % in filename #73

Dialga opened this issue Jun 9, 2021 · 5 comments
Labels
bug This is a bug

Comments

@Dialga
Copy link

Dialga commented Jun 9, 2021

For example hello%world.txt results in 400 Bad Request and hello%20world.txt results in File not found: ./hello world.txt.
Expected result is that these files are served correctly.
@xyproto
Copy link
Owner

xyproto commented Jun 9, 2021

Thanks for reporting! I'll look into this.

@xyproto xyproto added the planning-to-reproduce-the-issue Planning to reproduce the issue label Jun 9, 2021
@xyproto xyproto self-assigned this Jun 9, 2021
@xyproto xyproto added bug This is a bug and removed planning-to-reproduce-the-issue Planning to reproduce the issue labels Jun 24, 2021
@xyproto
Copy link
Owner

xyproto commented Jun 24, 2021

Confirmed. Serving "hello%world.txt" does not work.

@xyproto xyproto removed their assignment Jun 24, 2021
@Dialga
Copy link
Author

Dialga commented Aug 30, 2021

Just bumping.

Is this a WONTFIX?

@xyproto
Copy link
Owner

xyproto commented Aug 30, 2021

No, I'm still planning to fix this. Pull requests are welcome.

@xyproto
Copy link
Owner

xyproto commented Mar 24, 2022 •
edited

I added URL encoding of the links in the directory listings.

echo test > 'hello%world.txt'
algernon -x .

And then clicking hello%world.txt now works in main.

@xyproto xyproto closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xyproto @Dialga