Use CodeLingo to Address Further Issues

[CodeLingoTeam]

No description provided.

[CodeLingoTeam]

Hi @xyproto!
Thanks for merging the fixes from our earlier pull request. They were generated by CodeLingo which we've used to find a further 184 issues in the repo, listed below. This PR adds a set of CodeLingo Tenets which catch any new cases of the found issues in PRs to your repo.

For example, effective go considers exported functions without a doc comment to be a bad practice (implemented in this tenet).

Issues in your codebase

Exported function without a doc comment

permissions_test.go#L9
userstate_test.go#L267
userstate_test.go#L169
userstate_test.go#L9
userstate_test.go#L153
userstate_test.go#L251
userstate_test.go#L132
userstate_test.go#L63
userstate_test.go#L146
userstate_test.go#L45
userstate_test.go#L219
permissions.go#L70
permissions.go#L25
permissions.go#L31
permissions.go#L172
permissions.go#L41
permissions.go#L70
permissions.go#L85
permissions.go#L25
permissions.go#L121
permissions.go#L31
permissions.go#L172
permissions.go#L111
permissions.go#L41
permissions.go#L85
permissions.go#L116
permissions.go#L121
permissions.go#L57
permissions.go#L111
permissions.go#L47
permissions.go#L106
permissions.go#L116
userstate.go#L579
permissions.go#L57
permissions.go#L47
userstate.go#L51
userstate.go#L42
permissions.go#L106
userstate.go#L579
userstate.go#L537
userstate.go#L51
userstate.go#L42
userstate.go#L316
userstate.go#L97
userstate.go#L537
userstate.go#L478
userstate.go#L316
userstate.go#L532
userstate.go#L97
userstate.go#L520
userstate.go#L478
userstate.go#L555
userstate.go#L532
userstate.go#L544
userstate.go#L520
userstate.go#L460
userstate.go#L555
userstate.go#L527
userstate.go#L544
userstate.go#L163
userstate.go#L460
userstate.go#L473
userstate.go#L527
userstate.go#L735
userstate.go#L163
userstate.go#L569
userstate.go#L473
userstate.go#L607
userstate.go#L735
userstate.go#L589
userstate.go#L569
userstate.go#L607
userstate.go#L730
userstate.go#L589
userstate.go#L79
userstate.go#L730
userstate.go#L550
userstate.go#L79
userstate.go#L677
userstate.go#L550
userstate.go#L60
userstate.go#L677
examples/http/main.go#L26
userstate.go#L60
examples/http/main.go#L26

Boolean arguments that should be avoided as they can indicate low cohesion

userstate.go#L317
userstate.go#L103
userstate.go#L378
userstate.go#L169

Global variables that should be avoided to improve readability and reduce complexity

userstate.go#L25
userstate.go#L22

Exported functions without a corresponding test function

permissions.go#L71
permissions.go#L81
permissions.go#L127
permissions.go#L27
permissions.go#L76
permissions.go#L97
permissions.go#L33
permissions.go#L173
permissions.go#L92
permissions.go#L43
permissions.go#L86
permissions.go#L122
permissions.go#L112
permissions.go#L117
permissions.go#L59
permissions.go#L49
permissions.go#L102
permissions.go#L107
userstate.go#L326
userstate.go#L580
userstate.go#L240
userstate.go#L439
userstate.go#L55
userstate.go#L773
userstate.go#L397
userstate.go#L434
userstate.go#L230
userstate.go#L658
userstate.go#L344
userstate.go#L494
userstate.go#L489
userstate.go#L466
userstate.go#L46
userstate.go#L779
userstate.go#L484
userstate.go#L444
userstate.go#L539
userstate.go#L429
userstate.go#L455
userstate.go#L317
userstate.go#L103
userstate.go#L269
userstate.go#L419
userstate.go#L259
userstate.go#L479
userstate.go#L533
userstate.go#L353
userstate.go#L245
userstate.go#L522
userstate.go#L556
userstate.go#L546
userstate.go#L461
userstate.go#L755
userstate.go#L575
userstate.go#L585
userstate.go#L528
userstate.go#L169
userstate.go#L721
userstate.go#L474
userstate.go#L736
userstate.go#L570
userstate.go#L608
userstate.go#L500
userstate.go#L280
userstate.go#L235
userstate.go#L331
userstate.go#L597
userstate.go#L731
userstate.go#L82
userstate.go#L551
userstate.go#L678
userstate.go#L565
userstate.go#L449
userstate.go#L304
userstate.go#L63
userstate.go#L365
userstate.go#L712
userstate.go#L411
userstate.go#L250
userstate.go#L629
examples/iris/main.go#L19
examples/http/main.go#L27

TODOs in your code that should be tracked

userstate.go#L469

Untested publicly exported package

permissions.go#L2
hashing.go#L1
userstate.go#L1
examples/gin/main.go#L1
examples/iris/main.go#L1
examples/getdb/main.go#L1
examples/negroni/main.go#L1
examples/martini/main.go#L1
examples/goji/main.go#L1
examples/http/main.go#L1

CodeLingo will also send follow-up PRs to fix the existing repos in the codebase. Install CodeLingo GitHub app after merging this PR. It will always be free for open source.

We're most interested to see if we can help with project specific bugs. Tell us about more interesting issues and we'll see if our tech can help - free of charge.

Thanks,
Leila and the CodeLingo Team