fix: Implemented len assertion to avoid panic #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredfolkins
force-pushed
the
bug_cookies_range
branch
from
819c20e
to
de6d41c
Compare
|
Great, thank you! Merged. |
xyproto
added a commit
that referenced
this pull request
Apr 10, 2015
fix: Implemented len assertion to avoid panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy Alexander,
I found this bug last night while working on that other issue. In rare cases, because a len() assertion isn't performed, a malformed cookie could cause the application to panic. Fix and test are attached.
Thanks,
Jared