Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDT Needs Fail Cases #5

Closed
todo bot opened this issue Nov 16, 2019 · 1 comment
Closed

GDT Needs Fail Cases #5

todo bot opened this issue Nov 16, 2019 · 1 comment

Comments

@todo
Copy link

todo bot commented Nov 16, 2019

https://github.com/panix-os-dev-team/Panix-Rewrite/blob/db8febb98976cb91374edd3e5f23bce81abd066d/kernel/arch/i386/gdt.cpp#L68-L73

This issue was generated by todo based on a TODO comment in db8febb when #3 was merged. cc @panix-os-dev-team.
@todo todo bot added the todo 🗒️ label Nov 16, 2019
@Kfeavel Kfeavel changed the title Add return false to cases where operations don't succeed. GDT Needs Fail Cases Nov 16, 2019
@Kfeavel
Copy link
Member

Kfeavel commented Jan 14, 2020

There's no good way of doing this until interrupts are enabled (since it would panic), and we don't really need to test for it since it's a one time init. Closing since this is no longer a concern.

@Kfeavel Kfeavel closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kfeavel