Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore removes all vendor directories, even for plugins #38

Closed
BilboAtBagEnd opened this issue Apr 7, 2015 · 1 comment
Closed

.gitignore removes all vendor directories, even for plugins #38

BilboAtBagEnd opened this issue Apr 7, 2015 · 1 comment
Assignees
@xyu
Labels
bug

Comments

@BilboAtBagEnd
Copy link

.gitignore's vendor line should actually be

/vendor/

and not

vendor/

Otherwise all vendor directories, no matter where they are, are ignored, which results in broken plugins.
@xyu xyu added the bug label Apr 17, 2015
@xyu
Copy link
Owner

xyu commented Apr 17, 2015

Good call; please open a pull request to change it if you get around to it otherwise I'll make the change later this weekend.

@xyu xyu self-assigned this Apr 17, 2015
@xyu xyu closed this as completed in cc94526 Apr 18, 2015
sabih pushed a commit to sabih/heroku-wp that referenced this issue Dec 8, 2018
@xyu
Use absolute paths for .gitignore
76be600 
Make sure we use absolute paths so we don't ignore any of these paths in
subdirs. Resolves xyu#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xyu xyu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xyu @BilboAtBagEnd