Cursor execution not including names and types

[AchilleAsh]

Hi,

I've started to play with your lib and I've noticed one major bug when using the HTTP driver:

When calling the execute() method of a Cursor the SQL will not be appended with ' FORMAT TabSeparatedWithNamesAndTypes' as you could initially expect from the drivers/http/base.py file. This causes the result not to include the columns name and therefore the TSV post processing
(drivers/http/connector.py#195) will go wrong because the first 2 rows are actually data samples.

It seems to me that the following method of ClickHouseDialect_http

    def _execute(self, connection, sql):
        sql += ' FORMAT TabSeparatedWithNamesAndTypes'
        return connection.execute(sql)

is actually never called (Cursor or not), but I could be wrong.

One quick and easy fix could be to move this to the execute() method of Cursor.

Thanks,
Timothé

[xzkostyan]

Hi,

Yes, there is bug in direct HTTP cursor's execute() invocation. Native driver hasn't this disadvantage.

FORMAT clause was illegal in some queries as I remember. That's why this hack is located in two places. May be this situation is changed now.

In future I intend to switch default driver from http to native and maybe drop http support.

[xzkostyan]

It seems that this was fixed in #134.