Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 #134

Merged
merged 3 commits into from
Jul 26, 2021
Merged

#12 #134

merged 3 commits into from
Jul 26, 2021

Conversation

FishermanZzhang
Copy link
Contributor

No description provided.

@xzkostyan
Copy link
Owner

Please add some tests on this feature.

@FishermanZzhang
Copy link
Contributor Author

we use superset, found the problem(bug). superset use engine directly, not session.
engine dosn't has ClickHouseExecutionContext, therefore it dosn't add FORMAT_SUFFIX to statement

@xzkostyan xzkostyan merged commit 14958fb into xzkostyan:master Jul 26, 2021
xzkostyan added a commit that referenced this pull request Jul 26, 2021
@xzkostyan
Copy link
Owner

Sorry for merging delay.

lance0805 pushed a commit to lance0805/clickhouse-sqlalchemy that referenced this pull request Sep 17, 2021
lance0805 pushed a commit to lance0805/clickhouse-sqlalchemy that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants