-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async driver support #214
Async driver support #214
Conversation
3d991ee
to
ae3e9ad
Compare
need to set sqlalchemy>=1.4.24 (because of AdaptedConnection) |
@xzkostyan Is there something needed from me for PR to be merged? |
@randomowo the first step is green check. Good job. It's completed now. I'll take a detailed look on this PR in weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
Why do we have test "core" types (Int, Ip, date) behaviour in async version of native dialect? Isn't it redundant?
Async native dialect works a little differently (at least with different drivers) from sync, and I think we should test it separately, but on the other hand, we have types testing in the driver library. So if you still think it is redundant, I can remove it. |
You are right, we should test it separately. But async dialect inherited from the sync one: That's why, IMHO |
ok, i'll delete it soon |
Looks good to me. Let's make linter happy. |
dialect mostly fully copied from sqlalchemy.dialects.mysql.asyncmy