Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adding a duplicate column to the alembic table #275

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

leemurus
Copy link
Contributor

Fix problem with new sqlalchemy for alembic migrations.

What changed?

  • old sqlalchemy function table.append_column link
  • new sqlalchemy function table.append_column link

replace_existing: When True, allows replacing existing
columns. When False, the default, an warning will be raised
if a column with the same .key already exists. A future
version of sqlalchemy will instead rise a warning.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@coveralls
Copy link

Coverage Status

coverage: 85.756%. remained the same
when pulling 01ce534 on leemurus:fix/patch-alembic
into a5390b9 on xzkostyan:master.

@xzkostyan xzkostyan merged commit c34be61 into xzkostyan:master Dec 8, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants