Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Date32 Type #307

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Add Date32 Type #307

merged 7 commits into from
Apr 23, 2024

Conversation

BTheunissen
Copy link
Contributor

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@BTheunissen BTheunissen marked this pull request as ready for review April 2, 2024 23:01
@BTheunissen
Copy link
Contributor Author

Had some issues running the tests locally but can get these fixed by this afternoon.

@BTheunissen
Copy link
Contributor Author

Looks good now!

@BTheunissen
Copy link
Contributor Author

@xzkostyan Able to review? Should be passing all listing and test CI steps now.

@coveralls
Copy link

Coverage Status

coverage: 86.013% (+0.03%) from 85.988%
when pulling fe790f5 on BTheunissen:add-date32
into 83c5b46 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 7ad94b0 into xzkostyan:master Apr 23, 2024
73 of 79 checks passed
@BTheunissen BTheunissen deleted the add-date32 branch May 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Date32
3 participants
@BTheunissen @coveralls @xzkostyan