Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Nested Map Type (#314) #315

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Support Nested Map Type (#314) #315

merged 3 commits into from
Jun 10, 2024

Conversation

aksenof
Copy link
Contributor

@aksenof aksenof commented Jun 6, 2024

@aksenof
Copy link
Contributor Author

aksenof commented Jun 7, 2024

@xzkostyan
Hello, Konstantin. It's my first pull request. Just want fix bug for Map columns. We actively use clickhouse-sqlalchemy on my job. And this little fix help us with alembic revision autogenerate without error like in issue #314

@xzkostyan
Copy link
Owner

Hi.

Please write simple test for this bugfix. See example:

def test_nested_type(self):

@coveralls
Copy link

Coverage Status

coverage: 86.082%. remained the same
when pulling b15776f on aksenof:master
into f261350 on xzkostyan:master.

@aksenof
Copy link
Contributor Author

aksenof commented Jun 7, 2024

Done. Add tests.

@xzkostyan
Copy link
Owner

Please fix flake8 and tests will re-run.

@aksenof
Copy link
Contributor Author

aksenof commented Jun 10, 2024

flake8 fixed

@xzkostyan xzkostyan merged commit f434017 into xzkostyan:master Jun 10, 2024
90 checks passed
@coveralls
Copy link

Coverage Status

coverage: 86.082%. remained the same
when pulling 813e4f3 on aksenof:master
into f261350 on xzkostyan:master.

@aksenof
Copy link
Contributor Author

aksenof commented Jun 10, 2024

@xzkostyan
Please tell me if there is a release clickhouse-sqlalchemy on pypi coming soon? It is possible to release on next month with this bugfix?)

@xzkostyan
Copy link
Owner

@aksenof version 0.3.2 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested Map column
3 participants