add Decimal type support #38
Conversation
There was a problem hiding this comment.
If you plan to support HTTP transport you should add converter here: clickhouse_sqlalchemy/drivers/http/transport.py:22 and escape decimal value here: clickhouse_sqlalchemy/drivers/http/escaper.py:8.
Also, bump clickhouse-server version in .travis.yml to the minimum required,
|
I see that you've already implement escape_decimal in escaper.py, but I don't understand correctly how to convert value in the transport. It would be nice to quantize value before we send it to the server (because application can have non default decimal rounding rules), but I don't know how to get precision and scale from the SQLA column declaration. Could you help me please with this? |
|
This is a good question. There is no column context during escaping process. Okay. Let's bump clickhouse-server version and merge this PR. |
|
Hi. Your PR was merged into master. |
ClickHouse has supported Decimal type since 18.12.13 as experimental feature and since 18.14.9 as default feature. In this patch I've added support of Decimal type and simple test-cases that covers overflow and truncation behaviors.