Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array join support #44

Merged
merged 4 commits into from
Feb 14, 2019
Merged

array join support #44

merged 4 commits into from
Feb 14, 2019

Conversation

antonio-antuan
Copy link
Contributor

No description provided.

@antonio-antuan
Copy link
Contributor Author

какая-то странная багуля с query.count().

@antonio-antuan
Copy link
Contributor Author

Баг характерен для всех запросов, содержащих sample, array join. Отписал issue

@antonio-antuan antonio-antuan mentioned this pull request Jan 29, 2019
Closed
@coveralls
Copy link

coveralls commented Feb 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 89.711% when pulling c03313e on aCLr:feature/array_join into d753192 on xzkostyan:master.

xzkostyan
xzkostyan requested changes Feb 12, 2019
View reviewed changes
tests/orm/test_select.py Outdated Show resolved Hide resolved
@xzkostyan
Copy link
Owner

Осталось немного поправить flake8:

./tests/orm/test_select.py:1:1: F401 'sqlalchemy.literal_column' imported but unused

@xzkostyan xzkostyan merged commit 8e9d1e2 into xzkostyan:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzkostyan xzkostyan xzkostyan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antonio-antuan @coveralls @xzkostyan