Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed support for full parameter in joins #50

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fixed support for full parameter in joins #50

merged 1 commit into from
Feb 13, 2019

Conversation

vanzi
Copy link
Contributor

@vanzi vanzi commented Feb 13, 2019

The full parameter was not checked in visit_join, resulting in LEFT OUTER JOIN syntax regardless of its value.

Matches standard syntax:
https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/dialects/mysql/base.py#L1367

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.605% when pulling ca0b0a9 on PiwikPRO:master into d753192 on xzkostyan:master.

@xzkostyan xzkostyan merged commit 6cda1f7 into xzkostyan:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vanzi @coveralls @xzkostyan