New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

named arguments should go after positional #80

Merged

xzkostyan merged 2 commits into xzkostyan:master from sdrenn:minor-fix

Feb 15, 2020

sdrenn commented Feb 10, 2020

ReplacingMergeTree param version_col moved after *args, because named arguments should go after positional.

SummingMergeTree have same problem, but I don't know, how it shold work, so I didn't touch it.


          named arguments should go after positional

3bb7c3e

coveralls commented Feb 10, 2020 •

edited

Loading

Coverage increased (+0.006%) to 92.037% when pulling 59e3fb8 on sdrenn:minor-fix into 2f79283 on xzkostyan:master.


          version_col = kwargs.pop(version_col, None)

59e3fb8

xzkostyan merged commit 76ec893 into xzkostyan:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment