Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default values for optimize #26

Closed
CatherineH opened this issue Jun 4, 2014 · 5 comments
Closed

default values for optimize #26

CatherineH opened this issue Jun 4, 2014 · 5 comments

Comments

@CatherineH
Copy link
Collaborator

I think the default values for zOptimize should be numOfCycles = 0, algorithm=0, since these are the default values if you press enter in the optimization window in Zemax

@indranilsinharoy
Copy link
Collaborator

Hi Catherine,
Thanks for the input. You are right 👍 I think that will also save some typing. I should have done it that way the very first time :-). It will be updated in the next check in.

@CatherineH
Copy link
Collaborator Author

I did this in my fork. I also changed the zSetNSCSolve() to have default values for the pickup variables, because if you set the solve to variable it's annoying to have to set extraneous pickup info.

@indranilsinharoy
Copy link
Collaborator

That's awesome! I will look at the changes tonight and get back to you by tomorrow. Once we agree on the changes I would like to request you to send a pull request. Thanks a lot.

@indranilsinharoy
Copy link
Collaborator

Hi Catherine,
Good catch! Can you please send a pull request? Also, if possible can you please format argument list to zOptimize like this

def zOptimize(self, numOfCycles=0, algorithm=0, timeout=None)

instead of the current

def zOptimize(self, numOfCycles = 0, algorithm = 0, timeout=None)

Thanks a lot.

@indranilsinharoy
Copy link
Collaborator

Thanks, Catherine. Your changes have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants