-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default values for optimize #26
Comments
Hi Catherine, |
I did this in my fork. I also changed the zSetNSCSolve() to have default values for the pickup variables, because if you set the solve to variable it's annoying to have to set extraneous pickup info. |
That's awesome! I will look at the changes tonight and get back to you by tomorrow. Once we agree on the changes I would like to request you to send a pull request. Thanks a lot. |
Hi Catherine, def zOptimize(self, numOfCycles=0, algorithm=0, timeout=None) instead of the current def zOptimize(self, numOfCycles = 0, algorithm = 0, timeout=None) Thanks a lot. |
Thanks, Catherine. Your changes have been merged. |
I think the default values for zOptimize should be numOfCycles = 0, algorithm=0, since these are the default values if you press enter in the optimization window in Zemax
The text was updated successfully, but these errors were encountered: